Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pass lighthouse SEO audits #261

Merged

Conversation

jamesericdavidson
Copy link
Contributor

@jamesericdavidson jamesericdavidson commented Oct 25, 2024

Closes #259

  • theme toggle
  • sr-only theme toggle
  • sr-only hamburger menu
  • structured data validator needs account

@jamesericdavidson jamesericdavidson marked this pull request as ready for review October 25, 2024 20:53
@jamesericdavidson
Copy link
Contributor Author

@526avijitgupta Passes locally on mobile and desktop tests

image

@526avijitgupta
Copy link
Member

I have just re-enabled deploy previews from Netlify in the repository. Deploy previews had stopped working when we moved the repo to an organization I guess.
cc @yashmehrotra

@jamesericdavidson Could you please push an empty commit to trigger the deploy preview in this PR?

@yashmehrotra
Copy link
Collaborator

@526avijitgupta Thanks for fixing deploy previews

Can we merge this PR?

@526avijitgupta
Copy link
Member

I tested it locally, looks fine. Thanks @jamesericdavidson 🙌 merging

@526avijitgupta 526avijitgupta merged commit bf769be into gokarna-theme:main Oct 27, 2024
@jamesericdavidson jamesericdavidson deleted the refactor/lighthouse-seo branch October 27, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving Google Lighthouse SEO score
3 participants